Remove orc::gpu namespace
#17891
Merged
Remove orc::gpu namespace
#17891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
vuule
added
improvement
|
/ok to test |
PointKernel
approved these changes
Jan 31, 2025
mhaseeb123
reviewed
Jan 31, 2025
| namespace io { | ||
| namespace orc { | ||
| namespace gpu { | ||
| namespace cudf::io::orc::detail { |
mhaseeb123
approved these changes
Jan 31, 2025
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving forward with removal of the (redundant)
gpunamespace in cuIO.Also moved the entire ORC implementation to
cudf::io::orc::detail, leaving only the implementation of the public API incudf::io::orc.Also removed a few unused headers, or moved them to be included in the right files.
Checklist