Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disallow fallback to Make in Python builds #17894

Merged
merged 3 commits into from
Feb 4, 2025
Merged

disallow fallback to Make in Python builds #17894

merged 3 commits into from
Feb 4, 2025

Conversation

jameslamb
Copy link
Member

Description

Contributes to rapidsai/build-planning#146

Proposes:

  • setting [tool.scikit-build].ninja.make-fallback = false, so scikit-build-core will not silently fallback to using GNU Make if ninja is not available

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@jameslamb jameslamb added 2 - In Progress Currently a work in progress improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2025
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 31, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb jameslamb mentioned this pull request Jan 31, 2025
Open
@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Jan 31, 2025
@jameslamb jameslamb changed the title WIP: disallow fallback to Make in wheel builds WIP: disallow fallback to Make in Python builds Jan 31, 2025
@jameslamb
Copy link
Member Author

/ok to test

@jameslamb jameslamb changed the title WIP: disallow fallback to Make in Python builds disallow fallback to Make in Python builds Feb 3, 2025
@jameslamb jameslamb marked this pull request as ready for review February 3, 2025 13:54
@jameslamb jameslamb requested a review from a team as a code owner February 3, 2025 13:54
@jameslamb jameslamb requested a review from AyodeAwe February 3, 2025 13:54
@jameslamb jameslamb removed the 2 - In Progress Currently a work in progress label Feb 3, 2025
@vyasr
Copy link
Contributor

vyasr commented Feb 4, 2025

/merge

@rapids-bot rapids-bot bot merged commit b4eca89 into rapidsai:branch-25.04 Feb 4, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@AyodeAwe AyodeAwe Awaiting requested review from AyodeAwe AyodeAwe is a code owner automatically assigned from rapidsai/packaging-codeowners

Assignees

@jameslamb jameslamb

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jameslamb @vyasr @bdice