Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cudf.Scalar from factorize #17897

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Remove cudf.Scalar from factorize #17897

merged 5 commits into from
Feb 4, 2025

Conversation

mroeschke
Copy link
Contributor

Description

Toward #17843

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 31, 2025
@mroeschke mroeschke self-assigned this Jan 31, 2025
@mroeschke mroeschke requested a review from a team as a code owner January 31, 2025 23:43
@mroeschke mroeschke requested review from vyasr and bdice January 31, 2025 23:43
vyasr
vyasr approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vyasr
Copy link
Contributor

vyasr commented Feb 4, 2025

/merge

@rapids-bot rapids-bot bot merged commit 36b0f3a into rapidsai:branch-25.04 Feb 4, 2025
110 checks passed
@mroeschke mroeschke deleted the cln/cudf_scalar/factorize branch February 4, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@bdice bdice Awaiting requested review from bdice bdice is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@mroeschke mroeschke

Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @vyasr