Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Fix .str.cat when objects with different index are passed #5844

Merged
merged 14 commits into from
Aug 6, 2020
Merged

[REVIEW] Fix .str.cat when objects with different index are passed #5844

merged 14 commits into from
Aug 6, 2020

Conversation

galipremsagar
Copy link
Contributor

Fixes #5321

This PR handles and reindex's objects when objects of different indexes are passed to .str.cat.

@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer strings strings issues (C++ and Python) labels Aug 4, 2020
@galipremsagar galipremsagar requested a review from a team as a code owner August 4, 2020 18:52
@galipremsagar galipremsagar self-assigned this Aug 4, 2020
@GPUtester
Copy link
Collaborator

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

kkraus14
kkraus14 requested changes Aug 4, 2020
View reviewed changes
python/cudf/cudf/core/column/string.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/column/string.py Outdated Show resolved Hide resolved
python/cudf/cudf/tests/test_string.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 4, 2020 •
edited
Loading

Codecov Report

Merging #5844 into branch-0.15 will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.15    #5844      +/-   ##
===============================================
+ Coverage        84.11%   84.43%   +0.32%     
===============================================
  Files               80       80              
  Lines            13084    13406     +322     
===============================================
+ Hits             11006    11320     +314     
- Misses            2078     2086       +8
Impacted Files Coverage Δ
python/cudf/cudf/core/column/string.py 86.87% <100.00%> (+0.22%) ⬆️
python/cudf/cudf/io/feather.py 100.00% <0.00%> (ø)
python/cudf/cudf/comm/serialize.py 0.00% <0.00%> (ø)
python/custreamz/custreamz/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/_version.py 0.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_orc.py 100.00% <0.00%> (ø)
python/dask_cudf/dask_cudf/io/tests/test_json.py 100.00% <0.00%> (ø)
...ython/dask_cudf/dask_cudf/io/tests/test_parquet.py 100.00% <0.00%> (ø)
python/cudf/cudf/utils/applyutils.py 98.75% <0.00%> (+0.02%) ⬆️
python/cudf/cudf/core/join/join.py 92.41% <0.00%> (+0.03%) ⬆️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40dd54b...deb5d79. Read the comment docs.

kkraus14
kkraus14 requested changes Aug 4, 2020
View reviewed changes
python/cudf/cudf/core/column/string.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar changed the title [REVIEW] Fix .str.cat when objects with different index are passed [WIP] Fix .str.cat when objects with different index are passed Aug 5, 2020
@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 5, 2020
@galipremsagar galipremsagar removed the 2 - In Progress Currently a work in progress label Aug 6, 2020
@galipremsagar galipremsagar changed the title [WIP] Fix .str.cat when objects with different index are passed [REVIEW] Fix .str.cat when objects with different index are passed Aug 6, 2020
@galipremsagar galipremsagar changed the title [REVIEW] Fix .str.cat when objects with different index are passed [WIP] Fix .str.cat when objects with different index are passed Aug 6, 2020
@galipremsagar galipremsagar added 2 - In Progress Currently a work in progress and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 6, 2020
@galipremsagar galipremsagar changed the title [WIP] Fix .str.cat when objects with different index are passed [REVIEW] Fix .str.cat when objects with different index are passed Aug 6, 2020
@galipremsagar galipremsagar added 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer and removed 2 - In Progress Currently a work in progress labels Aug 6, 2020
@mike-wendt
Copy link
Contributor

rerun tests

@kkraus14 kkraus14 added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Aug 6, 2020
@galipremsagar galipremsagar merged commit 7e9aba7 into rapidsai:branch-0.15 Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkraus14 kkraus14 kkraus14 approved these changes

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge Python Affects Python cuDF API. strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] .str.cat should align with indices if indices are inequal
4 participants
@galipremsagar @GPUtester @mike-wendt @kkraus14