Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cugraph python build(s) to use scikit-build #2333

Closed
rlratzel opened this issue Jun 2, 2022 · 1 comment · Fixed by #2378
Closed

Update cugraph python build(s) to use scikit-build #2333

rlratzel opened this issue Jun 2, 2022 · 1 comment · Fixed by #2378
Assignees
@jnke2016
Milestone
22.08

Comments

@rlratzel
Copy link
Contributor

rlratzel commented Jun 2, 2022

RAPIDS is standardizing on scikit-build for building python packages, and cuGraph needs to be updated to stay current (cuML is doing the same). Here is a cuDF PR that can be used as a reference.

cc @vyasr @dantegd

For Developers below this line

  • [] Code passes CI
  • [] Code uses Graph Primitives
  • [] Code in C++/CUDA layer
  • [] Code in C layer
  • [] Code in pylibcugraph Python layer
  • [] Code in cugraph Python layer
  • [] Documentation
  • [] Test cases at each layer (for MG tests, a note in the PR description indicating the new/existing MG tests were run and passed)
@rlratzel rlratzel added ? - Needs Triage Need team to review and classify python labels Jun 2, 2022
@rlratzel rlratzel added this to the 22.08 milestone Jun 2, 2022
@jnke2016 jnke2016 mentioned this issue Jun 29, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jul 2, 2022

This issue has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this issue if no further response or action is needed. Otherwise, please respond with a comment indicating any updates or changes to the original issue and/or confirm this issue still needs to be addressed. This issue will be labeled inactive-90d if there is no activity in the next 60 days.

rapids-bot bot pushed a commit that referenced this issue Jul 29, 2022
@jnke2016
Update cugraph python build (#2378)
a1ef1de 
This PR updates cugraph python build to use scikit-build instead of setuptools. 
Scikit-build leverages cmake to build the python extension

closes #2333

Authors:
  - Joseph Nke (https://github.com/jnke2016)
  - Chuck Hastings (https://github.com/ChuckHastings)
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Brad Rees (https://github.com/BradReesWork)
  - Sevag H (https://github.com/sevagh)
  - Rick Ratzel (https://github.com/rlratzel)
  - Vyas Ramasubramani (https://github.com/vyasr)

URL: #2378
@kingmesal kingmesal removed the ? - Needs Triage Need team to review and classify label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jnke2016 jnke2016

Labels
None yet
Projects
None yet
Milestone
22.08
Development

Successfully merging a pull request may close this issue.

Update cugraph python build jnke2016/cugraph
3 participants
@rlratzel @kingmesal @jnke2016