Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Add mnmg out degree #1592

Merged
merged 4 commits into from
May 25, 2021
Merged

[REVIEW] Add mnmg out degree #1592

merged 4 commits into from
May 25, 2021

Conversation

Iroy30
Copy link
Contributor

@Iroy30 Iroy30 commented May 10, 2021

No description provided.

@Iroy30 Iroy30 requested a review from a team as a code owner May 10, 2021 15:52
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.06@7cb8583). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 2e90d3e differs from pull request most recent head 5f03ddb. Consider uploading reports for the commit 5f03ddb to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.06    #1592   +/-   ##
===============================================
  Coverage                ?   59.75%           
===============================================
  Files                   ?       79           
  Lines                   ?     3484           
  Branches                ?        0           
===============================================
  Hits                    ?     2082           
  Misses                  ?     1402           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cb8583...5f03ddb. Read the comment docs.

@Iroy30 Iroy30 added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 10, 2021
rlratzel
rlratzel reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just had one minor suggestion.

python/cugraph/structure/graph_primtypes_wrapper.pyx Outdated Show resolved Hide resolved
jnke2016
jnke2016 reviewed May 11, 2021
View reviewed changes
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@BradReesWork BradReesWork added this to the 21.06 milestone May 13, 2021
rlratzel
rlratzel approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the Direction enum much more than just x=1, x=2, etc.

@BradReesWork
Copy link
Member

rerun tests

@ajschmidt8 ajschmidt8 changed the title [REVIEW] Add mnmg out degree [REVIEW] Add mnmg out degree May 25, 2021
@BradReesWork
Copy link
Member

@gpucibot merge

@BradReesWork
Copy link
Member

rerun tests

@rapids-bot rapids-bot bot merged commit 0859228 into rapidsai:branch-21.06 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnke2016 jnke2016 jnke2016 left review comments

@rlratzel rlratzel rlratzel approved these changes

@BradReesWork BradReesWork BradReesWork approved these changes

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
21.06
Development

Successfully merging this pull request may close these issues.
5 participants
@Iroy30 @codecov-commenter @BradReesWork @rlratzel @jnke2016