Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the reduction op input parameter to host_scalar_(all)reduce utility functions. #1822

Merged

Conversation

seunghwak
Copy link
Contributor

Currently, host_scalar_(all)reduce assumes SUM reduction. Adding this input parameter will be necessary for other types of reductions (e.g. MAX).

@seunghwak seunghwak requested a review from a team as a code owner September 15, 2021 18:39
@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #1822 (3c5bb2d) into branch-21.10 (bf64c2c) will increase coverage by 9.72%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #1822      +/-   ##
================================================
+ Coverage         59.85%   69.57%   +9.72%     
================================================
  Files                77      139      +62     
  Lines              3547     8645    +5098     
================================================
+ Hits               2123     6015    +3892     
- Misses             1424     2630    +1206     
Impacted Files Coverage Δ
python/cugraph/layout/__init__.py
python/cugraph/dask/common/mg_utils.py
python/cugraph/utilities/utils.py
python/cugraph/dask/community/louvain.py
python/cugraph/dask/traversal/bfs.py
python/cugraph/community/subgraph_extraction.py
python/cugraph/sampling/random_walks.py
python/cugraph/community/louvain.py
python/cugraph/community/triangle_count.py
python/cugraph/structure/shuffle.py
... and 206 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44be72a...3c5bb2d. Read the comment docs.

@seunghwak
Copy link
Contributor Author

rerun tests

@ChuckHastings
Copy link
Collaborator

rerun tests

1 similar comment
@ChuckHastings
Copy link
Collaborator

rerun tests

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 032f86a into rapidsai:branch-21.10 Sep 19, 2021
@seunghwak seunghwak deleted the enh_add_op_to_host_scalar_reduce branch October 19, 2021 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants