Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed NetworkX requirement for type checks, fixed docstring, added new docstrings, import cleanups #1853

Merged

Conversation

rlratzel
Copy link
Contributor

Tested changes to optional import and type checking code by uninstalling NetworkX, observing the failure shown in #1851, applying change, then testing to observe the same script runs to completion without Nx installed.

closes #1851
closes #1807
closes #1782

@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Sep 28, 2021
@rlratzel rlratzel self-assigned this Sep 28, 2021
@rlratzel rlratzel requested a review from a team as a code owner September 28, 2021 03:41
@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2021

Codecov Report

Merging #1853 (b786f01) into branch-21.10 (177e9ad) will increase coverage by 0.49%.
The diff coverage is 86.00%.

❗ Current head b786f01 differs from pull request most recent head 42c536d. Consider uploading reports for the commit 42c536d to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #1853      +/-   ##
================================================
+ Coverage         69.59%   70.08%   +0.49%     
================================================
  Files               143      143              
  Lines              8675     8819     +144     
================================================
+ Hits               6037     6181     +144     
  Misses             2638     2638              
Impacted Files Coverage Δ
python/cugraph/cugraph/generators/rmat.py 34.44% <ø> (ø)
python/cugraph/cugraph/structure/graph_classes.py 76.84% <0.00%> (+0.55%) ⬆️
python/cugraph/cugraph/utilities/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/link_prediction/overlap.py 54.54% <50.00%> (-3.79%) ⬇️
python/cugraph/cugraph/link_prediction/sorensen.py 62.96% <50.00%> (-2.56%) ⬇️
python/cugraph/cugraph/utilities/utils.py 70.18% <75.00%> (+1.39%) ⬆️
...graph/cugraph/centrality/betweenness_centrality.py 90.16% <100.00%> (+0.16%) ⬆️
...thon/cugraph/cugraph/centrality/katz_centrality.py 89.47% <100.00%> (ø)
python/cugraph/cugraph/community/ecg.py 100.00% <100.00%> (ø)
python/cugraph/cugraph/community/egonet.py 92.10% <100.00%> (-0.21%) ⬇️
... and 78 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177e9ad...42c536d. Read the comment docs.

@BradReesWork BradReesWork added this to the 21.10 milestone Sep 28, 2021
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1397f6c into rapidsai:branch-21.10 Sep 28, 2021
@rlratzel rlratzel deleted the branch-21.10-doc_and_nx_import_fix branch June 17, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
4 participants