Added separate helpers for moving buffers to either cudf column and series objects #1915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…since columns are often acceptable and the extra conversion to series can be skipped.
…2-addcythoncolumnhelper
rlratzel
added
improvement
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #1915 +/- ##
===============================================
Coverage ? 69.53%
===============================================
Files ? 143
Lines ? 8626
Branches ? 0
===============================================
Hits ? 5998
Misses ? 2628
Partials ? 0 Continue to review full report at Codecov.
|
BradReesWork
approved these changes
Nov 3, 2021
ChuckHastings
approved these changes
Nov 3, 2021
jnke2016
approved these changes
Nov 3, 2021
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to address this feedback from #1901
This adds a separate cython helper for moving a buffer to a column to allow for a slightly more efficient call where column objects can be used.