Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional improvements to support (key, value) pairs when E/V is small and P is large #1919

Merged
merged 15 commits into from
Nov 9, 2021

Conversation

seunghwak
Copy link
Contributor

This PR pulls updates from #1916 & #1917. Better be reviewed after #1916 &#1917 gets merged.

(key, value) pairs are still disabled (by setting the threshold value to 0) as this has performance overhead and no clear benefit in analyzing larger graphs up to 32 GPUs (unless we artificially tweak 2D partitioning of GPUs). The threshold value needs to be adjusted with larger scale testing later.

  • Update copy_v_transform_reduce_in_out_nbr to use minor_properties_t as a temporary buffer.

@seunghwak seunghwak requested a review from a team as a code owner November 1, 2021 18:22
@seunghwak seunghwak self-assigned this Nov 1, 2021
@seunghwak seunghwak added DO NOT MERGE Hold off on merging; see PR for details Graph Prims improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 1, 2021
@seunghwak seunghwak added this to the 21.12 milestone Nov 1, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@d1e504a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 04133bb differs from pull request most recent head 75dd9a3. Consider uploading reports for the commit 75dd9a3 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12    #1919   +/-   ##
===============================================
  Coverage                ?   69.57%           
===============================================
  Files                   ?      143           
  Lines                   ?     8674           
  Branches                ?        0           
===============================================
  Hits                    ?     6035           
  Misses                  ?     2639           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1e504a...75dd9a3. Read the comment docs.

@seunghwak seunghwak added 3 - Ready for Review and removed DO NOT MERGE Hold off on merging; see PR for details labels Nov 3, 2021
@ChuckHastings
Copy link
Collaborator

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit df7bb9a into rapidsai:branch-21.12 Nov 9, 2021
@seunghwak seunghwak deleted the enh_enable_kv_pair branch January 27, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants