-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use CUB 1.15.0's new segmented sort #1977
Use CUB 1.15.0's new segmented sort #1977
Conversation
seunghwak
commented
Dec 3, 2021
•
edited
Loading
edited
- Update neighbor sort to use the new segmented sort.
- Update copy_v_transform_reduce_key_aggregated_out_nbr to use the new segmented sort (instead of a global sort) for the data already sorted by major vertices (e.g. previously segmented sort was slower than the global sort).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - still waiting on the rapids-make change.
Thanks for a quick review but this PR is still a work-in-progress :-) I will also experiment with this in copy_v_key_aggregated_out_nbr to see whether I can make the primitive faster. This pulls updates from #1976, so that PR may better be reviewed & merged first :-) |
rapidsai/rapids-cmake#138 tracks the work to upgrade thrust/cub to version 1.15.0 |
The rapids-cmake PR has been merged. I believe you can also remove the following workaround: https://github.com/rapidsai/cugraph/blob/branch-22.02/cpp/cmake/thirdparty/get_thrust.cmake#L21 |
Codecov Report
@@ Coverage Diff @@
## branch-22.02 #1977 +/- ##
===============================================
Coverage ? 70.75%
===============================================
Files ? 142
Lines ? 8860
Branches ? 0
===============================================
Hits ? 6269
Misses ? 2591
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |