-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dgl graph store #2046
Dgl graph store #2046
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.04 #2046 +/- ##
===============================================
Coverage ? 73.27%
===============================================
Files ? 154
Lines ? 9947
Branches ? 0
===============================================
Hits ? 7289
Misses ? 2658
Partials ? 0 Continue to review full report at Codecov.
|
@gpucibot merge |
Hi Brad, Thank you, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a concern about CuGraphStore class, it should have a to_device function or parameter in the sampling functions.
Thank you!
max_depth=length, use_padding=True) | ||
|
||
return p, w, s | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also have a function like async_fetch(self, ids, device):
in the cuGraphStore class? so we can send the sampled graphs to different GPUs.
Thank you!
new GraphStore for DGL intergration
Code will need to be added to DGL