Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate C++ conda recipes and add libcugraph-tests package #2124

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

jjacobelli
Copy link
Contributor

This PR includes the following changes:

  • Adds a libcugraph-tests package to the libcugraph recipe
    • This is a prerequisite for removing "Project Flash" from our build/CI scripts
    • The libcugraph-tests package was added as an additional output to the existing libcugraph recipe (which was renamed to libcugraph-split)
  • Consolidates remaining C++ recipes into libcugraph-split recipe
    • This gets rid of a lot of duplicate code between the recipes and reduces the number of times we have to call conda build in our CI scripts

@jjacobelli jjacobelli requested a review from a team as a code owner March 18, 2022 10:04
@jjacobelli jjacobelli marked this pull request as draft March 18, 2022 10:05
@jjacobelli jjacobelli self-assigned this Mar 18, 2022
@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function DO NOT MERGE Hold off on merging; see PR for details non-breaking Non-breaking change labels Mar 18, 2022
@jjacobelli jjacobelli added this to the 22.06 milestone Mar 18, 2022
@jjacobelli jjacobelli force-pushed the consolidate branch 2 times, most recently from bf113e3 to ce7d72a Compare March 18, 2022 12:10
@rlratzel
Copy link
Contributor

It looks like this PR has the same changes as #2094 . Can we close #2094?

@jjacobelli
Copy link
Contributor Author

It looks like this PR has the same changes as #2094 . Can we close #2094?

Yes, done

@jjacobelli jjacobelli changed the base branch from branch-22.04 to branch-22.06 March 24, 2022 09:13
@jjacobelli jjacobelli force-pushed the consolidate branch 2 times, most recently from 50cf80e to d7ad692 Compare March 28, 2022 09:11
@ajschmidt8 ajschmidt8 removed the DO NOT MERGE Hold off on merging; see PR for details label Mar 28, 2022
@jjacobelli jjacobelli force-pushed the consolidate branch 3 times, most recently from 2d27fcf to 9ef39c6 Compare March 29, 2022 17:51
@jjacobelli jjacobelli marked this pull request as ready for review March 29, 2022 17:55
@ajschmidt8
Copy link
Member

rerun tests

@jjacobelli
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #2124 (2dda127) into branch-22.06 (9956084) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 2dda127 differs from pull request most recent head a83908d. Consider uploading reports for the commit a83908d to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06    #2124      +/-   ##
================================================
+ Coverage         70.82%   70.86%   +0.04%     
================================================
  Files               170      170              
  Lines             11036    11036              
================================================
+ Hits               7816     7821       +5     
+ Misses             3220     3215       -5     
Impacted Files Coverage Δ
.../cugraph/tests/test_edge_betweenness_centrality.py 84.93% <0.00%> (+0.60%) ⬆️
...graph/cugraph/tests/test_betweenness_centrality.py 83.01% <0.00%> (+0.62%) ⬆️
python/cugraph/cugraph/tests/test_graph_store.py 100.00% <0.00%> (+1.56%) ⬆️
python/cugraph/cugraph/tests/test_utils.py 75.55% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9956084...a83908d. Read the comment docs.

Signed-off-by: Jordan Jacobelli <jjacobelli@nvidia.com>
@ajschmidt8
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 1e46f7b into rapidsai:branch-22.06 Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants