Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renaming detail space functions #2212

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

seunghwak
Copy link
Contributor

To address the comment in #2117 (comment)

Device kernels for graph primitives for different vertex degree ranges had been named for_all_major_for_all_nbr_.... This is subject to naming conflicts and @kaatish established a better naming convention to avoid this. This PR applies the same naming conventions to other graph primitives.

@seunghwak seunghwak requested a review from a team as a code owner April 7, 2022 18:31
@seunghwak seunghwak self-assigned this Apr 7, 2022
@seunghwak seunghwak added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 7, 2022
@seunghwak seunghwak added this to the 22.06 milestone Apr 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2022

Codecov Report

Merging #2212 (653e690) into branch-22.06 (38be932) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@               Coverage Diff                @@
##           branch-22.06    #2212      +/-   ##
================================================
+ Coverage         70.82%   70.86%   +0.04%     
================================================
  Files               170      170              
  Lines             11036    11036              
================================================
+ Hits               7816     7821       +5     
+ Misses             3220     3215       -5     
Impacted Files Coverage Δ
python/cugraph/cugraph/structure/hypergraph.py 90.00% <100.00%> (ø)
.../cugraph/tests/test_edge_betweenness_centrality.py 84.93% <0.00%> (+0.60%) ⬆️
...graph/cugraph/tests/test_betweenness_centrality.py 83.01% <0.00%> (+0.62%) ⬆️
python/cugraph/cugraph/tests/test_graph_store.py 100.00% <0.00%> (+1.56%) ⬆️
python/cugraph/cugraph/tests/test_utils.py 75.55% <0.00%> (+4.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f545fa5...653e690. Read the comment docs.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit cd9d7ed into rapidsai:branch-22.06 Apr 11, 2022
@seunghwak seunghwak deleted the enh_detail_naming branch August 11, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants