Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undirected graph support for MG graphs #2247

Merged

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Apr 26, 2022

This PR allows our MG implementation to support undirected graph by symmetrizing the dataframe. This will be consistent with the SG implementation.

It also

  • replaces the deprecated cudf call append by concat
  • update Neighborhood sampling's docstring and code to only support int32 vertices and labels by Dylan

closes #2240
closes #2174
closes #2264 by raising a ValueError and updating the docstring

@jnke2016 jnke2016 requested a review from a team as a code owner April 26, 2022 19:32
@jnke2016 jnke2016 changed the title Undirected graph support for MG graphs [Draft] Undirected graph support for MG graphs Apr 26, 2022
@jnke2016 jnke2016 changed the title [Draft] Undirected graph support for MG graphs [DRAFT] Undirected graph support for MG graphs Apr 27, 2022
@rlratzel rlratzel added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python labels Apr 30, 2022
@rlratzel rlratzel added this to the 22.06 milestone Apr 30, 2022
@rlratzel rlratzel changed the title [DRAFT] Undirected graph support for MG graphs Undirected graph support for MG graphs May 5, 2022
@jnke2016 jnke2016 requested a review from a team as a code owner May 6, 2022 15:06
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2022

Codecov Report

Merging #2247 (9b9eba1) into branch-22.06 (38be932) will decrease coverage by 0.98%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.06    #2247      +/-   ##
================================================
- Coverage         70.82%   69.83%   -0.99%     
================================================
  Files               170      173       +3     
  Lines             11036    11435     +399     
================================================
+ Hits               7816     7986     +170     
- Misses             3220     3449     +229     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 89.65% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 88.23% <ø> (-1.24%) ⬇️
python/cugraph/cugraph/community/egonet.py 97.36% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 85.29% <ø> (ø)
...cugraph/cugraph/dask/centrality/katz_centrality.py 25.00% <ø> (ø)
python/cugraph/cugraph/dask/common/input_utils.py 22.13% <ø> (+0.57%) ⬆️
python/cugraph/cugraph/dask/common/mg_utils.py 30.43% <ø> (-7.07%) ⬇️
python/cugraph/cugraph/dask/common/part_utils.py 19.23% <ø> (-0.94%) ⬇️
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 081df0a...9b9eba1. Read the comment docs.

Joseph Nke added 4 commits May 6, 2022 20:17
@ajschmidt8 ajschmidt8 removed the request for review from a team May 9, 2022 18:40
@ajschmidt8
Copy link
Member

Removing ops-codeowners from the required reviews since it doesn't seem there are any file changes that we're responsible for. Feel free to add us back if necessary.

@rlratzel
Copy link
Contributor

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e906c98 into rapidsai:branch-22.06 May 11, 2022
@jnke2016 jnke2016 deleted the undirected_graph_support_for_mg_graphs branch September 24, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
5 participants