-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Update some clustering algos to only support undirected graphs #2267
[BUG] Update some clustering algos to only support undirected graphs #2267
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2267 +/- ##
=================================================
- Coverage 63.97% 23.87% -40.10%
=================================================
Files 100 100
Lines 4436 4435 -1
=================================================
- Hits 2838 1059 -1779
- Misses 1598 3376 +1778
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few minor requests.
@gpucibot merge |
Our current implementation of
Louvain
,Leiden
,KTruss
andTriangle Count
only supportundirected graphs
. To enforce that, we are currently raising anexception
if a graph is not oftype Graph
but this is ineffective if a user create acugraph.Graph
with the parameterdirected=True
This PR
directed=True
when creating acugraph.Graph
closes #2263