-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bindings for triangle counting #2273
add bindings for triangle counting #2273
Conversation
rerun tests |
…6-fea_add_triangle_counting_bindings
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2273 +/- ##
================================================
- Coverage 63.55% 63.09% -0.46%
================================================
Files 102 104 +2
Lines 4547 4653 +106
================================================
+ Hits 2890 2936 +46
- Misses 1657 1717 +60
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good, just a few requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, we should probably have some minimal test coverage in pylibcugraph
for triangle count - I didn't see a new test in pylibcugraph.
@@ -71,3 +71,6 @@ | |||
|
|||
from pylibcugraph.katz_centrality import EXPERIMENTAL__katz_centrality | |||
katz_centrality = experimental_warning_wrapper(EXPERIMENTAL__katz_centrality) | |||
|
|||
from pylibcugraph.triangle_count import triangle_count |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Triangle count is a new pylibcugraph binding, so it wouldn't have been in experimental for a release. Is the promoted from experimental warning necessary in that case / having it also in experimental?
…6-fea_add_triangle_counting_bindings
…dd a deprecation warning to the current one
…6-fea_add_triangle_counting_bindings
@gpucibot merge |
This PR add python bindings for triangle counting.
cuGraph
andpylibcuGraph
tests completedFails when sampling some vertices from the graph that will be used as parameter (
start_list
) for the MG implementationThe SG implementation works with and without
start_list