Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bindings for triangle counting #2273

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented May 16, 2022

This PR add python bindings for triangle counting.
cuGraph and pylibcuGraph tests completed

Fails when sampling some vertices from the graph that will be used as parameter (start_list) for the MG implementation

The SG implementation works with and without start_list

@jnke2016 jnke2016 requested a review from a team as a code owner May 16, 2022 03:27
@BradReesWork BradReesWork added this to the 22.06 milestone May 19, 2022
@BradReesWork BradReesWork added 3 - Ready for Review improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 19, 2022
@BradReesWork
Copy link
Member

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #2273 (6caaa2b) into branch-22.06 (008273b) will decrease coverage by 0.45%.
The diff coverage is 43.39%.

❗ Current head 6caaa2b differs from pull request most recent head 30d55ac. Consider uploading reports for the commit 30d55ac to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06    #2273      +/-   ##
================================================
- Coverage         63.55%   63.09%   -0.46%     
================================================
  Files               102      104       +2     
  Lines              4547     4653     +106     
================================================
+ Hits               2890     2936      +46     
- Misses             1657     1717      +60     
Impacted Files Coverage Δ
python/cugraph/cugraph/dask/link_analysis/hits.py 18.75% <ø> (ø)
...aph/cugraph/dask/sampling/neighborhood_sampling.py 0.00% <ø> (ø)
...n/cugraph/cugraph/dask/community/triangle_count.py 17.54% <17.54%> (ø)
...h/cugraph/experimental/community/triangle_count.py 67.50% <67.50%> (ø)
python/cugraph/cugraph/community/triangle_count.py 100.00% <100.00%> (ø)
python/cugraph/cugraph/dask/__init__.py 100.00% <100.00%> (ø)
python/cugraph/cugraph/dask/community/__init__.py 100.00% <100.00%> (ø)
python/cugraph/cugraph/experimental/__init__.py 100.00% <100.00%> (ø)
...pylibcugraph/pylibcugraph/experimental/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 008273b...30d55ac. Read the comment docs.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just a few requests.

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we should probably have some minimal test coverage in pylibcugraph for triangle count - I didn't see a new test in pylibcugraph.

@@ -71,3 +71,6 @@

from pylibcugraph.katz_centrality import EXPERIMENTAL__katz_centrality
katz_centrality = experimental_warning_wrapper(EXPERIMENTAL__katz_centrality)

from pylibcugraph.triangle_count import triangle_count
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Triangle count is a new pylibcugraph binding, so it wouldn't have been in experimental for a release. Is the promoted from experimental warning necessary in that case / having it also in experimental?

@rlratzel
Copy link
Contributor

rlratzel commented Jun 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5da5be7 into rapidsai:branch-22.06 Jun 1, 2022
@jnke2016 jnke2016 deleted the branch-22.06-fea_add_triangle_counting_bindings branch September 24, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants