-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add and test mechanism for creating graph with edge index as weight #2288
Add and test mechanism for creating graph with edge index as weight #2288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
cpp/tests/c_api/mg_test_utils.cpp
Outdated
@@ -191,3 +191,102 @@ extern "C" int create_mg_test_graph(const cugraph_resource_handle_t* handle, | |||
|
|||
return test_ret_value; | |||
} | |||
extern "C" int create_mg_test_graph_with_ids(const cugraph_resource_handle_t* handle, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with_edge_ids
might be more intuitive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in latest push
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #2288 +/- ##
================================================
- Coverage 63.82% 63.69% -0.14%
================================================
Files 100 100
Lines 4484 4481 -3
================================================
- Hits 2862 2854 -8
- Misses 1622 1627 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested. It looks good to me
@gpucibot merge |
Missed this in the last uniform neighborhood sampling updates.
Added a mechanism for creating a graph using an edge index as the weight. This is a temporary mechanism until we add direct support for edge indexes in the graph.