Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SG and MG SSSP to pylibcugraph #2295

Merged

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented May 20, 2022

Uses the pylibcugraph C API to make these calls instead of the wrapper functions. Removes wrapper functions from the code.

@alexbarghi-nv alexbarghi-nv added python non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels May 20, 2022
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review May 20, 2022 19:01
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner May 20, 2022 19:01
@BradReesWork BradReesWork added this to the 22.06 milestone May 24, 2022
@alexbarghi-nv
Copy link
Member Author

Needs to be merged after #2305

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #2295 (f3567de) into branch-22.06 (38be932) will decrease coverage by 6.95%.
The diff coverage is n/a.

❗ Current head f3567de differs from pull request most recent head d41effa. Consider uploading reports for the commit d41effa to get more accurate results

@@               Coverage Diff                @@
##           branch-22.06    #2295      +/-   ##
================================================
- Coverage         70.82%   63.86%   -6.96%     
================================================
  Files               170      100      -70     
  Lines             11036     4519    -6517     
================================================
- Hits               7816     2886    -4930     
+ Misses             3220     1633    -1587     
Impacted Files Coverage Δ
python/cugraph/cugraph/__init__.py 100.00% <ø> (ø)
python/cugraph/cugraph/centrality/__init__.py 100.00% <ø> (ø)
...graph/cugraph/centrality/betweenness_centrality.py 89.65% <ø> (ø)
...on/cugraph/cugraph/centrality/degree_centrality.py 81.81% <ø> (ø)
...thon/cugraph/cugraph/centrality/katz_centrality.py 88.23% <ø> (-1.24%) ⬇️
python/cugraph/cugraph/community/egonet.py 97.36% <ø> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <ø> (+2.94%) ⬆️
python/cugraph/cugraph/community/leiden.py 100.00% <ø> (+7.69%) ⬆️
python/cugraph/cugraph/community/louvain.py 100.00% <ø> (+7.69%) ⬆️
python/cugraph/cugraph/community/triangle_count.py 100.00% <ø> (+11.11%) ⬆️
... and 129 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0c6a9e...d41effa. Read the comment docs.

@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review May 25, 2022 12:28
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner May 25, 2022 12:28
@alexbarghi-nv alexbarghi-nv marked this pull request as draft May 25, 2022 12:34
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review May 25, 2022 15:36
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two quick changes.

python/cugraph/cugraph/dask/traversal/sssp.py Outdated Show resolved Hide resolved
python/cugraph/cugraph/traversal/sssp.py Outdated Show resolved Hide resolved
Copy link
Contributor

@jnke2016 jnke2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@alexbarghi-nv
Copy link
Member Author

@BradReesWork Rick's requested changes are done, you can override the blocker and merge this.

@rlratzel
Copy link
Contributor

rlratzel commented Jun 1, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 861cef0 into rapidsai:branch-22.06 Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants