Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix (providing invalid sentinel value for cuCollection). #2382

Merged
merged 2 commits into from
Jul 5, 2022

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Jun 30, 2022

  • Fix when value_t is vertex_t
  • Fix when value_t is not vertex_t (and can be any arithmetic or thrust::tuple of arithmetic types).

@seunghwak seunghwak requested a review from a team as a code owner June 30, 2022 23:59
@seunghwak seunghwak self-assigned this Jun 30, 2022
@seunghwak seunghwak added bug Something isn't working 2 - In Progress non-breaking Non-breaking change labels Jul 1, 2022
@seunghwak seunghwak added this to the 22.08 milestone Jul 1, 2022
@seunghwak seunghwak changed the title [WIP] Bug fix (providing invalid sentinel value for cuCollection). Bug fix (providing invalid sentinel value for cuCollection). Jul 1, 2022
@jjacobelli
Copy link
Contributor

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2022

Codecov Report

Merging #2382 (a75dbd0) into branch-22.08 (fe776f2) will increase coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.08    #2382      +/-   ##
================================================
+ Coverage         60.08%   60.10%   +0.01%     
================================================
  Files               102      102              
  Lines              5158     5158              
================================================
+ Hits               3099     3100       +1     
+ Misses             2059     2058       -1     
Impacted Files Coverage Δ
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe776f2...a75dbd0. Read the comment docs.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 3a27fa5 into rapidsai:branch-22.08 Jul 5, 2022
@seunghwak seunghwak deleted the bug_cuco_sentinel_value branch August 11, 2022 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants