Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix handling of fanout == -1 #2435

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix handling of fanout == -1 #2435

merged 1 commit into from
Jul 22, 2022

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Jul 20, 2022 •
edited
Loading

Uniform neighbor sampling isn't working properly with fanout specifying -1.

The partially_decompress_edge_partition_to_fill_edgelist function didn't handle SG properly.

closes #2425

@ChuckHastings ChuckHastings requested a review from a team as a code owner July 20, 2022 19:03
@ChuckHastings ChuckHastings self-assigned this Jul 20, 2022
@ChuckHastings ChuckHastings added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Jul 20, 2022
@ChuckHastings ChuckHastings added this to the 22.08 milestone Jul 20, 2022
@VibhuJawa VibhuJawa mentioned this pull request Jul 20, 2022
Closed
@ChuckHastings
Copy link
Collaborator Author

rerun tests

3 similar comments
@ChuckHastings
Copy link
Collaborator Author

rerun tests

@ChuckHastings
Copy link
Collaborator Author

rerun tests

@ChuckHastings
Copy link
Collaborator Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2022 •
edited
Loading

Codecov Report

Merging #2435 (7936fb3) into branch-22.08 (23f9444) will increase coverage by 0.25%.
The diff coverage is n/a.

@@               Coverage Diff                @@
##           branch-22.08    #2435      +/-   ##
================================================
+ Coverage         60.13%   60.39%   +0.25%     
================================================
  Files               102      102              
  Lines              5155     5244      +89     
================================================
+ Hits               3100     3167      +67     
- Misses             2055     2077      +22
Impacted Files Coverage Δ
python/cugraph/cugraph/gnn/graph_store.py 76.66% <0.00%> (-3.34%) ⬇️
python/cugraph/cugraph/__init__.py 100.00% <0.00%> (ø)
python/cugraph/cugraph/dask/comms/comms.py 34.06% <0.00%> (ø)
python/cugraph/cugraph/dask/common/mg_utils.py 30.43% <0.00%> (ø)
python/cugraph/cugraph/dask/common/input_utils.py 22.13% <0.00%> (ø)
...ython/cugraph/cugraph/community/ktruss_subgraph.py 88.23% <0.00%> (+2.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23f9444...7936fb3. Read the comment docs.

@ChuckHastings
Copy link
Collaborator Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5788f02 into rapidsai:branch-22.08 Jul 22, 2022
@ChuckHastings ChuckHastings deleted the fix_uniform_neighbor_sample_fanout_-1 branch August 4, 2022 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seunghwak seunghwak seunghwak approved these changes

Assignees

@ChuckHastings ChuckHastings

Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
22.08
Development

Successfully merging this pull request may close these issues.

[FEA] Support getting all the neighboring edges for the uniform_neighbor_sample
3 participants
@ChuckHastings @codecov-commenter @seunghwak