Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW]Hetrograph and dask_cudf support #2592

Merged
merged 25 commits into from
Sep 30, 2022

Conversation

VibhuJawa
Copy link
Member

@VibhuJawa VibhuJawa commented Aug 17, 2022

This PR fixes https://github.com/rapidsai/graph_dl/issues/27

This PR fixes https://github.com/rapidsai/graph_dl/issues/43

This PR fixes https://github.com/rapidsai/graph_dl/issues/39

Tests Added:

Single GPU:

  • APIs like num_nodes, num_edges
  • test_sampling_basic
  • test_sampling_homogeneous_gs_in_dir
  • test_sampling_homogeneous_gs_out_dir
  • test_sampling_gs_homogeneous_neg_one_fanout
  • test_sampling_gs_heterogeneous_in_dir
  • test_sampling_gs_heterogeneous_out_dir
  • test_sampling_gs_heterogeneous_neg_one_fanout

Multi GPU:

  • APIs like num_nodes, num_edges
  • test_sampling_basic
  • test_sampling_homogeneous_gs_in_dir
  • test_sampling_homogeneous_gs_out_dir
  • test_sampling_gs_homogeneous_neg_one_fanout
  • test_sampling_gs_heterogeneous_in_dir
  • test_sampling_gs_heterogeneous_out_dir
  • test_sampling_gs_heterogeneous_neg_one_fanout

Bugs to reproduce:

Tests that depend upon #2523

  • Add minimal example to PR to ensure it gets fixed
    Added comment here: PropertyGraph set index to vertex and edge ids #2523 (review)
  • test_get_node_storage_gs (Failing cause of a PG bug)
  • test_get_edge_storage_gs (Failing cause of a PG bug)
  • test_get_node_storage_gs (Failing cause of a PG bug)
  • test_get_edge_storage_gs (Failing cause of a PG bug)

@BradReesWork BradReesWork added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 17, 2022
@BradReesWork BradReesWork added this to the 22.10 milestone Aug 17, 2022
@VibhuJawa VibhuJawa changed the base branch from branch-22.10 to branch-21.08 September 2, 2022 14:39
@VibhuJawa VibhuJawa changed the base branch from branch-21.08 to branch-22.10 September 2, 2022 14:39
@VibhuJawa VibhuJawa changed the title [WIP]Hetrograph support [WIP]Hetrograph and dask_cudf support Sep 6, 2022
@VibhuJawa VibhuJawa force-pushed the heto_graph_support branch 2 times, most recently from 46cd9dd to 2bd6dd3 Compare September 26, 2022 23:39
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.10@5e98efb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.10    #2592   +/-   ##
===============================================
  Coverage                ?   58.79%           
===============================================
  Files                   ?      111           
  Lines                   ?     6184           
  Branches                ?        0           
===============================================
  Hits                    ?     3636           
  Misses                  ?     2548           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@VibhuJawa VibhuJawa marked this pull request as ready for review September 29, 2022 04:12
@VibhuJawa VibhuJawa requested a review from a team as a code owner September 29, 2022 04:12
@VibhuJawa VibhuJawa changed the title [WIP]Hetrograph and dask_cudf support [REVIEW]Hetrograph and dask_cudf support Sep 29, 2022
@BradReesWork
Copy link
Member

rerun tests

@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit e852b3c into rapidsai:branch-22.10 Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants