Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds mechanism to skip notebook directories for different run types #2693

Merged
merged 8 commits into from
Sep 22, 2022
Merged

adds mechanism to skip notebook directories for different run types #2693

merged 8 commits into from
Sep 22, 2022

Conversation

acostadon
Copy link
Contributor

closes #2622

@acostadon acostadon added feature request New feature or request Notebook non-breaking Non-breaking change labels Sep 13, 2022
@acostadon acostadon self-assigned this Sep 13, 2022
@acostadon acostadon added this to the 22.10 milestone Sep 13, 2022
@acostadon acostadon marked this pull request as ready for review September 20, 2022 00:29
@acostadon acostadon requested review from a team as code owners September 20, 2022 00:29
@alexbarghi-nv
Copy link
Member

rerun tests

ci/gpu/notebook_list.py Outdated Show resolved Hide resolved
ci/gpu/notebook_list.py Outdated Show resolved Hide resolved
Comment on lines 58 to 60
#if runtype not in ['ci', 'nightly', 'weekly']:
# print(f'Unknown Run Type = {runtype}', file=sys.stderr)
# exit()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dead code that can be removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to be a test for an unrecognized run type, I added the new default 'all' to the valid types and uncommented.
Changed run types and skip files to a dictionary and modified this check to check the dictionary

ci/gpu/notebook_list.py Outdated Show resolved Hide resolved
ci/gpu/test-notebooks.sh Outdated Show resolved Hide resolved
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a291cfe into rapidsai:branch-22.10 Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Update CI build to only run algorithm notebooks
5 participants