-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds mechanism to skip notebook directories for different run types #2693
adds mechanism to skip notebook directories for different run types #2693
Conversation
in the directory with the notebook
rerun tests |
ci/gpu/notebook_list.py
Outdated
#if runtype not in ['ci', 'nightly', 'weekly']: | ||
# print(f'Unknown Run Type = {runtype}', file=sys.stderr) | ||
# exit() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this dead code that can be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meant to be a test for an unrecognized run type, I added the new default 'all' to the valid types and uncommented.
Changed run types and skip files to a dictionary and modified this check to check the dictionary
@gpucibot merge |
closes #2622