Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a random selection primitive #2703

Merged
merged 16 commits into from
Sep 27, 2022

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Sep 14, 2022

Add a primitive to support randomly selecting (without biases) vertex neighbors.

Also, refactored primitive tests to avoid duplicating code for vertex/edge source/edge destination property value generation.

@seunghwak seunghwak added feature request New feature or request 2 - In Progress non-breaking Non-breaking change labels Sep 14, 2022
@seunghwak seunghwak added this to the 22.10 milestone Sep 14, 2022
@seunghwak seunghwak self-assigned this Sep 14, 2022
@seunghwak seunghwak requested a review from a team as a code owner September 14, 2022 17:33
@seunghwak seunghwak requested a review from a team as a code owner September 23, 2022 03:22
@seunghwak seunghwak changed the title [WIP][skip-ci] Implement a random selection primitive Implement a random selection primitive Sep 23, 2022
@seunghwak
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Base: 60.04% // Head: 60.04% // No change to project coverage 👍

Coverage data is based on head (726ff2c) compared to base (3eb2b40).
Patch has no changes to coverable lines.

❗ Current head 726ff2c differs from pull request most recent head e8d3ce9. Consider uploading reports for the commit e8d3ce9 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.10    #2703   +/-   ##
=============================================
  Coverage         60.04%   60.04%           
=============================================
  Files               111      111           
  Lines              6184     6184           
=============================================
  Hits               3713     3713           
  Misses             2471     2471           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@naimnv naimnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed over the changes. This PR contains a good set of changes to understand how prims should be written :) Will go though the files at later point to understand them better.

@ChuckHastings
Copy link
Collaborator

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5e98efb into rapidsai:branch-22.10 Sep 27, 2022
rapids-bot bot pushed a commit that referenced this pull request Oct 3, 2022
Closes #2581 
Closes #2582
Closes #2665

Update the neighborhood sampling algorithm to use the new neighborhood sampling primitive defined in #2703

Authors:
  - Chuck Hastings (https://github.com/ChuckHastings)

Approvers:
  - Seunghwa Kang (https://github.com/seunghwak)

URL: #2751
@seunghwak seunghwak deleted the fea_random_select_prim branch October 20, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants