C++ implementation for unweighted Jaccard/Sorensen/Overlap #2750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChuckHastings
added
2 - In Progress
improvement
ChuckHastings
changed the title
naimnv
approved these changes
Oct 3, 2022
ChuckHastings
changed the title
|
rerun tests |
naimnv
approved these changes
Oct 3, 2022
seunghwak
approved these changes
Oct 3, 2022
| src/community/detail/common_methods_mg.cu | ||
| src/community/detail/common_methods_sg.cu | ||
| src/detail/utility_wrappers.cu | ||
| src/structure/graph_view_mg.cu |
There was a problem hiding this comment.
Mainly for curiosity, why did you move graph_view_mg.cu to here?
There was a problem hiding this comment.
Ninja tracing showed that it take 217 seconds to compile. I basically moved everything that was slow (by the unscientific method of my eyes looking at the graphic) up to the top to get it started earlier in the parallel schedule.
|
@gpucibot merge |
Codecov ReportBase: 59.79% // Head: 59.81% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #2750 +/- ##
================================================
+ Coverage 59.79% 59.81% +0.01%
================================================
Files 111 111
Lines 6184 6388 +204
================================================
+ Hits 3698 3821 +123
- Misses 2486 2567 +81
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2543
Implements unweighted similarity algorithms using the new primitive defined in #2728.
Weighted implementations will be tracked by issue #2749