Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MG tests bugs #2819

Merged

Conversation

jnke2016
Copy link
Contributor

@jnke2016 jnke2016 commented Oct 17, 2022

A 22.10 PR leveraging the datasets API broke the MG batch_betweenness_centrality and batch_edge_betweenness_centrality. In fact, both tests are calling their non batch SG counterparts tests but with non datasets API objects leading to AttributeError: 'str' object has no attribute 'get_graph'. Another 22.10 PR which repartitioned the dask dataframe also broke the above tests including the MG replication tests. In fact, those algos/function with batch_enable=True expect only one partition which will later be replicated across all workers during the replication call.

This PR fixes the above issues by not repartitioning the dask dataframe when batch_enable=True and also leverages the datasets API for MG batch_betweenness_centrality and batch_edge_betweenness_centrality

closes #2815

@jnke2016 jnke2016 requested a review from a team as a code owner October 17, 2022 22:12
@jnke2016
Copy link
Contributor Author

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@ed39ddb). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #2819   +/-   ##
===============================================
  Coverage                ?   60.44%           
===============================================
  Files                   ?      111           
  Lines                   ?     6515           
  Branches                ?        0           
===============================================
  Hits                    ?     3938           
  Misses                  ?     2577           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rlratzel rlratzel added bug Something isn't working non-breaking Non-breaking change labels Oct 18, 2022
@rlratzel rlratzel added this to the 22.12 milestone Oct 18, 2022
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 00ae9ed into rapidsai:branch-22.12 Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MG tests failing
4 participants