-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
key, value store abstraction #2920
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
seunghwak
commented
Nov 11, 2022
•
edited
Loading
edited
- create an abstract class to store (key, value) pairs and support searching with keys.
- The abstract class can either use binary search or hash table (NVIDIA cuCollection) for search.
- If value type is not directly supported by cuCollection (e.g. if not bitwise comparable or trivially copyable), we store key, value_index pairs in a cuCollection object and use the retrieved value_index to find a value.
- Update cugraph C++ code and per_v_transform_reduce_dst_key_aggregated_outgoing_e to use this abstraction (the latter is necessary to support (key, value) pairs with thrust::tuple type values; this is necessary for Leiden).
seunghwak
added
2 - In Progress
improvement
Improvement / enhancement to an existing function
non-breaking
Non-breaking change
labels
Nov 11, 2022
…ore utility functions to work with kv_store_t
seunghwak
changed the title
[WIP] key, value store abstraction
key, value store abstraction
Nov 14, 2022
@naimnv Please review this, and now the |
naimnv
approved these changes
Nov 15, 2022
ChuckHastings
approved these changes
Nov 15, 2022
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.