Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use CMake 3.25.0 as it has a FindCUDAToolkit show stopping bug #2957

Merged

Conversation

robertmaynard
Copy link
Contributor

No description provided.

@robertmaynard robertmaynard requested review from a team as code owners November 17, 2022 19:42
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.12@3d95eee). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head e14ba13 differs from pull request most recent head 96b535b. Consider uploading reports for the commit 96b535b to get more accurate results

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-22.12    #2957   +/-   ##
===============================================
  Coverage                ?   60.55%           
===============================================
  Files                   ?      123           
  Lines                   ?     7003           
  Branches                ?        0           
===============================================
  Hits                    ?     4241           
  Misses                  ?     2762           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vyasr vyasr added bug Something isn't working 3 - Ready for Review non-breaking Non-breaking change labels Nov 17, 2022
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like everything, good to see no build requirements in the new packages.

@BradReesWork BradReesWork added this to the 22.12 milestone Nov 18, 2022
@BradReesWork
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 5e1baf1 into rapidsai:branch-22.12 Nov 18, 2022
@robertmaynard robertmaynard deleted the bug/avoid_cmake_3.25.0 branch November 21, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants