MGPropertyGraph: fix OOM when renumbering by type #3123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rapidsai#3110 Previously, all data for a single type would be collected in a single partition, which could easily overwhelm a worker or GPU. We now sort by multiple columns to ensure data can be evenly distributed.
BradReesWork
added
improvement
|
Looks good; was just wondering what the impact on runtime would be. |
|
/merge |
rlratzel
approved these changes
Jan 12, 2023
Codecov ReportBase: 55.31% // Head: 55.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## branch-23.02 #3123 +/- ##
================================================
- Coverage 55.31% 55.20% -0.11%
================================================
Files 148 142 -6
Lines 9423 9229 -194
================================================
- Hits 5212 5095 -117
+ Misses 4211 4134 -77 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3110
Previously, all data for a single type would be collected in a single partition, which could easily overwhelm a worker or GPU.
We now sort by multiple columns to ensure data can be evenly distributed.