Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uniform sampling code cleanup and minor performance tuning #3238

Merged
merged 21 commits into from
Feb 9, 2023

Conversation

seunghwak
Copy link
Contributor

@seunghwak seunghwak commented Feb 6, 2023

Code clean-up and minor performance tuning.

@seunghwak seunghwak requested a review from a team as a code owner February 6, 2023 18:14
@seunghwak seunghwak self-assigned this Feb 6, 2023
@seunghwak seunghwak added this to the 23.04 milestone Feb 6, 2023
@seunghwak seunghwak added improvement Improvement / enhancement to an existing function 5 - Merge After Dependencies non-breaking Non-breaking change DO NOT MERGE Hold off on merging; see PR for details and removed 5 - Merge After Dependencies labels Feb 6, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2023

Codecov Report

❗ No coverage uploaded for pull request base (branch-23.04@42b1393). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@               Coverage Diff               @@
##             branch-23.04    #3238   +/-   ##
===============================================
  Coverage                ?   56.26%           
===============================================
  Files                   ?      153           
  Lines                   ?     9658           
  Branches                ?        0           
===============================================
  Hits                    ?     5434           
  Misses                  ?     4224           
  Partials                ?        0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@seunghwak seunghwak removed the DO NOT MERGE Hold off on merging; see PR for details label Feb 8, 2023
@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit 16cd876 into rapidsai:branch-23.04 Feb 9, 2023
@seunghwak seunghwak deleted the enh_uniform_sample_perf branch May 5, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants