-
Notifications
You must be signed in to change notification settings - Fork 302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg #3382
Merged
rapids-bot
merged 36 commits into
rapidsai:branch-23.04
from
alexbarghi-nv:cugraph-pyg-drop-cupy
Apr 3, 2023
Merged
Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg #3382
rapids-bot
merged 36 commits into
rapidsai:branch-23.04
from
alexbarghi-nv:cugraph-pyg-drop-cupy
Apr 3, 2023
+47
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cugraph into update-ci-for-pyg
…to update-ci-for-pyg
alexbarghi-nv
changed the title
Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg
[skip-ci] Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg
Mar 28, 2023
alexbarghi-nv
changed the title
[skip-ci] Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg
Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg
Mar 28, 2023
rlratzel
approved these changes
Mar 29, 2023
VibhuJawa
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 4, 2023
- Adds new examples for cugraph-pyg. - Removes outdated examples. - Moves MG scripts to top-level directory. - Makes the input to `_get_vertex_groups_from_sample` a tensor instead of Series - Adds `is_sorted` arg to `_get_vertex_groups_from_sample` to skip sorting if tensor already sorted - Some fixes to `CuGraphStore` for running multi-GPU workflows Merge after #3288 - merged Merge after #3289 - merged Merge after #3382 - merged Closes #3316 Closes #3226 Closes #3072 Authors: - Alex Barghi (https://github.com/alexbarghi-nv) Approvers: - Vibhu Jawa (https://github.com/VibhuJawa) - Rick Ratzel (https://github.com/rlratzel) URL: #3326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves an issue where the wrong version of
searchsorted
caused a device to host copy. Also removes the backend option fromCuGraphStore
entirely to prevent similar bugs from happening in the future and better align cugraph-pyg with the pyg/pytorch ecosystem.Merge after #3289
Closes #2995