Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg #3382

Merged
merged 36 commits into from
Apr 3, 2023

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Mar 28, 2023

Resolves an issue where the wrong version of searchsorted caused a device to host copy. Also removes the backend option from CuGraphStore entirely to prevent similar bugs from happening in the future and better align cugraph-pyg with the pyg/pytorch ecosystem.

Merge after #3289
Closes #2995

@alexbarghi-nv alexbarghi-nv self-assigned this Mar 28, 2023
@alexbarghi-nv alexbarghi-nv added the bug Something isn't working label Mar 28, 2023
@alexbarghi-nv alexbarghi-nv added the breaking Breaking change label Mar 28, 2023
@alexbarghi-nv alexbarghi-nv added this to the 23.04 milestone Mar 28, 2023
@alexbarghi-nv alexbarghi-nv changed the title Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg [skip-ci] Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg Mar 28, 2023
@alexbarghi-nv alexbarghi-nv changed the title [skip-ci] Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg Use Correct Searchsorted Function and Drop cupy from CuGraphStore in cugraph-pyg Mar 28, 2023
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review March 28, 2023 20:35
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner March 28, 2023 20:35
Copy link
Member

@VibhuJawa VibhuJawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BradReesWork BradReesWork added the Blocked Cannot progress due to external reasons label Mar 30, 2023
@alexbarghi-nv alexbarghi-nv removed the Blocked Cannot progress due to external reasons label Apr 3, 2023
@alexbarghi-nv
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 7b28710 into rapidsai:branch-23.04 Apr 3, 2023
rapids-bot bot pushed a commit that referenced this pull request Apr 4, 2023
- Adds new examples for cugraph-pyg.
- Removes outdated examples.
- Moves MG scripts to top-level directory.
- Makes the input to `_get_vertex_groups_from_sample` a tensor instead of Series
- Adds `is_sorted` arg to `_get_vertex_groups_from_sample` to skip sorting if tensor already sorted
- Some fixes to `CuGraphStore` for running multi-GPU workflows

Merge after #3288  - merged
Merge after #3289  - merged
Merge after #3382  - merged

Closes #3316 
Closes #3226 
Closes #3072

Authors:
  - Alex Barghi (https://github.com/alexbarghi-nv)

Approvers:
  - Vibhu Jawa (https://github.com/VibhuJawa)
  - Rick Ratzel (https://github.com/rlratzel)

URL: #3326
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIX]: Always use PyTorch in CuGraphStore
4 participants