Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CUDA_TRY with RAFT_CUDA_TRY #3389

Merged
merged 3 commits into from
Mar 29, 2023
Merged

Conversation

naimnv
Copy link
Contributor

@naimnv naimnv commented Mar 28, 2023

Replace CUDA_TRY with RAFT_CUDA_TRY in three files.

Also replaced CHECK_CUDA with RAFT_CHECK_CUDA

rapidsai/raft#1304 removed the old macros, we still had a few references.

Currently blocked by https://github.com/rapidsai/cugraph-ops/pull/448... once that is merged we should be able to finish building and merge this.

@naimnv naimnv requested a review from a team as a code owner March 28, 2023 23:50
@naimnv naimnv added the non-breaking Non-breaking change label Mar 28, 2023
@naimnv naimnv added this to the 23.04 milestone Mar 28, 2023
@naimnv naimnv removed the request for review from jnke2016 March 28, 2023 23:52
@naimnv naimnv added the bug Something isn't working label Mar 28, 2023
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChuckHastings ChuckHastings added Blocked Cannot progress due to external reasons and removed Blocked Cannot progress due to external reasons labels Mar 29, 2023
@ChuckHastings
Copy link
Collaborator

/merge

@rapids-bot rapids-bot bot merged commit b45fb8d into rapidsai:branch-23.04 Mar 29, 2023
@naimnv naimnv deleted the minor-fix branch April 4, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants