-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Biased RW implementation and test #4499
base: branch-24.10
Are you sure you want to change the base?
Biased RW implementation and test #4499
Conversation
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on your first PR!!!
…/MG and N2V SG: Passing all tests N2V MG: failing larger datasets
@seunghwak @ChuckHastings |
/okay to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
A number of things to improve the quality. A question for @seunghwak to perhaps improve code reuse.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Part 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Part 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few suggestions for minor fixes. Otherwise, looks good to me and thank you for your contribution!!!
/okay to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @G-Cornett. Thanks for your work this summer!
/ok to test |
Biased random walk selector implemented. Tests changed to accurately reflect expected behavior.
closes #2555