Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Explanatory Error Message for uint Types #4556

Merged
merged 9 commits into from
Aug 13, 2024

Conversation

alexbarghi-nv
Copy link
Member

Clarify that unsigned integer types are not supported as vertex ids in the error message. Resolves issue reported by @ogreen.

@alexbarghi-nv alexbarghi-nv self-assigned this Jul 26, 2024
@alexbarghi-nv alexbarghi-nv added the improvement Improvement / enhancement to an existing function label Jul 26, 2024
@github-actions github-actions bot removed the conda label Jul 26, 2024
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review July 26, 2024 19:25
@alexbarghi-nv alexbarghi-nv requested a review from a team as a code owner July 26, 2024 19:26
@alexbarghi-nv alexbarghi-nv added this to the 24.10 milestone Jul 26, 2024
@alexbarghi-nv alexbarghi-nv added the non-breaking Non-breaking change label Jul 26, 2024
@alexbarghi-nv
Copy link
Member Author

@rlratzel can you re-review? All changes should be addressed now.

@alexbarghi-nv
Copy link
Member Author

/merge

@alexbarghi-nv
Copy link
Member Author

/merge

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rapids-bot rapids-bot bot merged commit 1ef3f56 into rapidsai:branch-24.10 Aug 13, 2024
131 checks passed
@alexbarghi-nv alexbarghi-nv deleted the fix-error-msg branch August 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants