Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEA] Biased Sampling in cuGraph-PyG #4586

Merged
merged 16 commits into from
Aug 19, 2024

Conversation

alexbarghi-nv
Copy link
Member

@alexbarghi-nv alexbarghi-nv commented Aug 1, 2024

Enables biased sampling in PylibcuGraph and cuGraph-PyG. Also fixes a memory issue that was revealed by calling biased sampling instead of uniform neighbor sampling; the loader was pre-allocating more memory than needed.

  • Update pylibcugraph
  • Update dist sampler in cugraph
  • Correctness testing
  • Make issue for PyG upstream (here)

@alexbarghi-nv alexbarghi-nv self-assigned this Aug 1, 2024
@github-actions github-actions bot added the python label Aug 1, 2024
@alexbarghi-nv alexbarghi-nv added feature request New feature or request non-breaking Non-breaking change and removed python labels Aug 1, 2024
@alexbarghi-nv alexbarghi-nv added this to the 24.10 milestone Aug 1, 2024
@github-actions github-actions bot added the python label Aug 1, 2024
@github-actions github-actions bot added the CMake label Aug 1, 2024
@alexbarghi-nv alexbarghi-nv marked this pull request as ready for review August 2, 2024 19:53
@alexbarghi-nv alexbarghi-nv requested review from a team as code owners August 2, 2024 19:53
Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor things which need not hold up my approval. I suspect @VibhuJawa might be a better reviewer.

python/cugraph-pyg/cugraph_pyg/data/graph_store.py Outdated Show resolved Hide resolved
@alexbarghi-nv
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 4c26e7a into rapidsai:branch-24.10 Aug 19, 2024
103 checks passed
alexbarghi-nv added a commit to rapidsai/cugraph-gnn that referenced this pull request Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake feature request New feature or request non-breaking Non-breaking change python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants