Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate get_sampling_index function from cugraph-ops to cugraph #4594

Merged

Conversation

ChuckHastings
Copy link
Collaborator

@ChuckHastings ChuckHastings commented Aug 6, 2024

This PR copies the source files from cugraph-ops that provide the get_sampling_index function into the cugraph source code. The code was placed in a single source directory (src/from_cugraph_ops) and cleaned up a little bit to remove parts of the cugraph-ops infrastructure that were unused.

There are still improvements that could be made, but this should be functional in allowing us to avoid using the version from cugraph-ops.

closes #4592

@ChuckHastings ChuckHastings self-assigned this Aug 12, 2024
@ChuckHastings ChuckHastings added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 12, 2024
@ChuckHastings ChuckHastings marked this pull request as ready for review August 13, 2024 17:33
@ChuckHastings ChuckHastings requested review from a team as code owners August 13, 2024 17:33
Copy link
Contributor

@seunghwak seunghwak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving packaging changes

@ChuckHastings
Copy link
Collaborator Author

/merge

@rapids-bot rapids-bot bot merged commit b8ae82e into rapidsai:branch-24.10 Aug 20, 2024
103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake cuGraph improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate cugraph-ops sampling kernel into cugraph
3 participants