Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Changes to NearestNeighbors to call 2d random ball cover #4003

Merged
merged 34 commits into from
Sep 29, 2021
Merged

[REVIEW] Changes to NearestNeighbors to call 2d random ball cover #4003

merged 34 commits into from
Sep 29, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jun 22, 2021

This PR integrates the random ball cover PoC into cuml's brute-force knn for executing the random ball cover algorithm for haversine distance.

@cjnolet cjnolet requested a review from a team as a code owner June 22, 2021 17:05
@cjnolet cjnolet added 2 - In Progress Currenty a work in progress Experimental Used to denote experimental features improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed CUDA/C++ labels Jun 22, 2021
@github-actions github-actions bot added CMake CUDA/C++ Cython / Python Cython or Python issue labels Jun 24, 2021
@cjnolet cjnolet requested review from a team as code owners September 1, 2021 18:59
@cjnolet cjnolet changed the base branch from branch-21.08 to branch-21.10 September 1, 2021 18:59
@cjnolet cjnolet requested a review from a team as a code owner September 1, 2021 18:59
@github-actions github-actions bot added the gpuCI gpuCI issue label Sep 1, 2021
@cjnolet cjnolet changed the title [REVIEW] Changes to knn to call random ball cover for haversine knn [REVIEW] Changes to knn to call 2d random ball cover Sep 7, 2021
@cjnolet cjnolet changed the title [REVIEW] Changes to knn to call 2d random ball cover [REVIEW] Changes to NearestNeighbors to call 2d random ball cover Sep 7, 2021
ajschmidt8
ajschmidt8 approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@ajschmidt8 ajschmidt8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving ops-codeowner file changes

dantegd
dantegd requested changes Sep 20, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good in the cuML side, just left review as request changes for the change of raft pin back to branch-21.10

ci/local/build.sh Show resolved Hide resolved
cpp/cmake/thirdparty/get_raft.cmake Outdated Show resolved Hide resolved
python/cuml/neighbors/nearest_neighbors.pyx Outdated Show resolved Hide resolved
python/cuml/test/test_nearest_neighbors.py Show resolved Hide resolved
@github-actions github-actions bot removed the CMake label Sep 24, 2021
@dantegd
Copy link
Member

dantegd commented Sep 27, 2021

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Sep 27, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Sep 29, 2021

@gpucibot merge

@cjnolet
Copy link
Member Author

cjnolet commented Sep 29, 2021

rerun tests

1 similar comment
@cjnolet
Copy link
Member Author

cjnolet commented Sep 29, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

Merging #4003 (6545f76) into branch-21.10 (0b5b10f) will decrease coverage by 0.00%.
The diff coverage is 86.36%.

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-21.10    #4003      +/-   ##
================================================
- Coverage         86.06%   86.06%   -0.01%     
================================================
  Files               231      231              
  Lines             18656    18691      +35     
================================================
+ Hits              16057    16087      +30     
- Misses             2599     2604       +5
Flag Coverage Δ
dask 47.01% <38.63%> (-0.03%) ⬇️
non-dask 78.75% <86.36%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/cuml/neighbors/__init__.py 100.00% <ø> (ø)
python/cuml/neighbors/nearest_neighbors.pyx 92.28% <86.36%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b5b10f...6545f76. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 5a8889d into rapidsai:branch-21.10 Sep 29, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Changes to NearestNeighbors to call 2d random ball cover (rapidsai#4003)
0416194 
This PR integrates the [random ball cover PoC](rapidsai/raft#213) into cuml's brute-force knn for executing the random ball cover algorithm for haversine distance.

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)
  - Dante Gama Dessavre (https://github.com/dantegd)
  - Paul Taylor (https://github.com/trxcllnt)

Approvers:
  - AJ Schmidt (https://github.com/ajschmidt8)
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4003
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
2 - In Progress Currenty a work in progress CUDA/C++ Cython / Python Cython or Python issue Experimental Used to denote experimental features gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cjnolet @dantegd @codecov-commenter @ajschmidt8 @trxcllnt