Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double fit crash in preprocessing models #4040

Merged
merged 1 commit into from
Jul 11, 2021
Merged

Fix double fit crash in preprocessing models #4040

merged 1 commit into from
Jul 11, 2021

Conversation

viclafargue
Copy link
Contributor

@viclafargue viclafargue commented Jul 9, 2021 •
edited by dantegd
Loading

Solves #4034

@viclafargue viclafargue requested a review from a team as a code owner July 9, 2021 12:15
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jul 9, 2021
@viclafargue viclafargue added bug Something isn't working non-breaking Non-breaking change labels Jul 9, 2021
dantegd
dantegd approved these changes Jul 11, 2021
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the tests as well as the fix :)

@dantegd dantegd mentioned this pull request Jul 11, 2021
Open
@dantegd
Copy link
Member

dantegd commented Jul 11, 2021

rerun tests

@dantegd
Copy link
Member

dantegd commented Jul 11, 2021

@gpucibot merge

@dantegd dantegd added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Jul 11, 2021
@rapids-bot rapids-bot bot merged commit 7613040 into rapidsai:branch-21.08 Jul 11, 2021
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@91abe67). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4040   +/-   ##
===============================================
  Coverage                ?   85.66%           
===============================================
  Files                   ?      230           
  Lines                   ?    18349           
  Branches                ?        0           
===============================================
  Hits                    ?    15718           
  Misses                  ?     2631           
  Partials                ?        0
Flag Coverage Δ
dask 48.14% <0.00%> (?)
non-dask 78.04% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91abe67...39017f6. Read the comment docs.

@dantegd dantegd mentioned this pull request Jul 12, 2021
Closed
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@viclafargue
Fix double fit crash in preprocessing models (rapidsai#4040)
3b2e71f 
Solves rapidsai#4034

Authors:
  - Victor Lafargue (https://github.com/viclafargue)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4040
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@viclafargue @dantegd @codecov-commenter