Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REVIEW] Adding quick notes to HDBSCAN public API docs as to why discrepancies may occur between cpu and gpu impls. #4061

Merged
merged 2 commits into from
Jul 22, 2021
Merged

[REVIEW] Adding quick notes to HDBSCAN public API docs as to why discrepancies may occur between cpu and gpu impls. #4061

merged 2 commits into from
Jul 22, 2021

Conversation

cjnolet
Copy link
Member

@cjnolet cjnolet commented Jul 16, 2021 •
edited
Loading

Closes #4042

@cjnolet cjnolet requested review from a team as code owners July 16, 2021 19:20
@github-actions github-actions bot added CUDA/C++ Cython / Python Cython or Python issue labels Jul 16, 2021
@cjnolet cjnolet added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change and removed CUDA/C++ Cython / Python Cython or Python issue labels Jul 16, 2021
@cjnolet
Copy link
Member Author

cjnolet commented Jul 17, 2021

rerun tests

1 similar comment
@dantegd
Copy link
Member

dantegd commented Jul 17, 2021

rerun tests

@cjnolet cjnolet mentioned this pull request Jul 20, 2021
Open
@cjnolet
Copy link
Member Author

cjnolet commented Jul 20, 2021

rerun tests

@cjnolet
Copy link
Member Author

cjnolet commented Jul 22, 2021

rerun tests

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@eaa2add). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08    #4061   +/-   ##
===============================================
  Coverage                ?   85.60%           
===============================================
  Files                   ?      230           
  Lines                   ?    18403           
  Branches                ?        0           
===============================================
  Hits                    ?    15754           
  Misses                  ?     2649           
  Partials                ?        0
Flag Coverage Δ
dask 48.35% <0.00%> (?)
non-dask 78.03% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaa2add...3f7a603. Read the comment docs.

@dantegd
Copy link
Member

dantegd commented Jul 22, 2021

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 2972a7d into rapidsai:branch-21.08 Jul 22, 2021
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@cjnolet
Adding quick notes to HDBSCAN public API docs as to why discrepancies…
d0d5ee0 
… may occur between cpu and gpu impls. (rapidsai#4061)

Closes rapidsai#4042

Authors:
  - Corey J. Nolet (https://github.com/cjnolet)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4061
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add docs describing for users when the GPU impl might not match CPU (due to difference in KNN and MST)
3 participants
@cjnolet @dantegd @codecov-commenter