Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove classmethod of SimpleImputer #4439

Merged
merged 1 commit into from
Feb 24, 2022
Merged

Remove classmethod of SimpleImputer #4439

merged 1 commit into from
Feb 24, 2022

Conversation

lowener
Copy link
Contributor

@lowener lowener commented Dec 10, 2021

Closes #4341.
The classmethod decorator seems to not be useful here and is blocking the serialization of SimpleImputer.

@lowener lowener requested a review from a team as a code owner December 10, 2021 13:02
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Dec 10, 2021
@lowener lowener added 3 - Ready for Review Ready for review by team bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change and removed Cython / Python Cython or Python issue labels Dec 10, 2021
viclafargue
viclafargue approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@viclafargue viclafargue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change. Let's see what CI gives, but should normally not cause any issue.

wphicks
wphicks approved these changes Dec 10, 2021
View reviewed changes
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange... Looks like that was never intended to be a classmethod to begin with. It references self and uses attributes that suggest self is indeed the object, not the class. I'm surprised it hasn't already caused other issues.

Anyway, LGTM!

@wphicks
Copy link
Contributor

wphicks commented Dec 10, 2021

@gpucibot merge

@dantegd
Copy link
Member

dantegd commented Dec 13, 2021

rerun tests

@wphicks wphicks added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Dec 16, 2021
@github-actions
Copy link

This PR has been labeled inactive-30d due to no recent activity in the past 30 days. Please close this PR if it is no longer required. Otherwise, please respond with a comment indicating any updates. This PR will be labeled inactive-90d if there is no activity in the next 60 days.

@dantegd
Copy link
Member

dantegd commented Jan 24, 2022

rerun tests

@lowener
Copy link
Contributor Author

lowener commented Feb 3, 2022

rerun tests

@dantegd dantegd changed the base branch from branch-22.02 to branch-22.04 February 24, 2022 04:43
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.04@0114c67). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-22.04    #4439   +/-   ##
===============================================
  Coverage                ?   84.90%           
===============================================
  Files                   ?      251           
  Lines                   ?    21649           
  Branches                ?        0           
===============================================
  Hits                    ?    18380           
  Misses                  ?     3269           
  Partials                ?        0
Flag Coverage Δ
dask 44.51% <0.00%> (?)
non-dask 78.55% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0114c67...781a2a7. Read the comment docs.

@rapids-bot rapids-bot bot merged commit 779d71b into rapidsai:branch-22.04 Feb 24, 2022
@lowener lowener deleted the 22.02-imputer-fix branch February 24, 2022 10:06
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@lowener
Remove classmethod of SimpleImputer (rapidsai#4439)
6b7c8ec 
Closes rapidsai#4341.
The `classmethod` decorator seems to not be useful here and is blocking the serialization of SimpleImputer.

Authors:
  - Micka (https://github.com/lowener)

Approvers:
  - Victor Lafargue (https://github.com/viclafargue)
  - William Hicks (https://github.com/wphicks)

URL: rapidsai#4439
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viclafargue viclafargue viclafargue approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] SimpleImputer lost the fitted state when it was dumped/reloaded with pickle
5 participants
@lowener @wphicks @dantegd @codecov-commenter @viclafargue