Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require UCX 1.12.1+ #4720

Merged
merged 1 commit into from
May 5, 2022
Merged

Require UCX 1.12.1+ #4720

merged 1 commit into from
May 5, 2022

Conversation

jakirkham
Copy link
Member

@jakirkham jakirkham requested a review from a team as a code owner May 2, 2022 23:09
@github-actions github-actions bot added the conda conda issue label May 2, 2022
@jakirkham jakirkham marked this pull request as draft May 2, 2022 23:15
@dantegd
Copy link
Member

dantegd commented May 3, 2022

rerun tests

@jakirkham jakirkham marked this pull request as ready for review May 4, 2022 03:35
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@6ca7254). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06    #4720   +/-   ##
===============================================
  Coverage                ?   88.85%           
===============================================
  Files                   ?      371           
  Lines                   ?    34655           
  Branches                ?        0           
===============================================
  Hits                    ?    30791           
  Misses                  ?     3864           
  Partials                ?        0
Flag Coverage Δ
dask 34.24% <0.00%> (?)
non-dask 84.17% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ca7254...598262a. Read the comment docs.

@jakirkham
Copy link
Member Author

Looks like this is working. Could someone please add labels for this?

jjacobelli
jjacobelli reviewed May 4, 2022
View reviewed changes
conda/recipes/libcuml/conda_build_config.yaml
@@ -4,6 +4,9 @@ cmake_version:
nccl_version:
- ">=2.9.9"

ucx_version:
- "1.12.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be >=1.12.1

Copy link
Member Author

@jakirkham jakirkham May 5, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as here ( rapidsai/raft#638 (comment) ). Let's keep the discussion in that thread for now 🙂

conda/recipes/libcuml/meta.yaml
@@ -71,6 +72,7 @@ outputs:
- libraft-nn {{ minor_version }}
- cudf {{ minor_version }}
- nccl {{ nccl_version }}
- ucx >={{ ucx_version }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the >= here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above.

@jjacobelli jjacobelli added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels May 4, 2022
@dantegd
Copy link
Member

dantegd commented May 5, 2022

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7e91505 into rapidsai:branch-22.06 May 5, 2022
@jakirkham jakirkham deleted the ucx_1_12_1 branch May 5, 2022 21:04
vimarsh6739 pushed a commit to vimarsh6739/cuml that referenced this pull request Oct 9, 2023
@jakirkham
Require UCX 1.12.1+ (rapidsai#4720)
6a79490 
xref: rapidsai/integration#471

Authors:
  - https://github.com/jakirkham

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)
  - William Hicks (https://github.com/wphicks)
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#4720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjacobelli jjacobelli jjacobelli left review comments

@dantegd dantegd dantegd approved these changes

@raydouglass raydouglass raydouglass approved these changes

@wphicks wphicks wphicks approved these changes

Assignees
No one assigned
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jakirkham @dantegd @codecov-commenter @raydouglass @wphicks @jjacobelli