Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for SVC fit_proba not using class weights #5912

Merged
merged 7 commits into from
Jun 15, 2024
Merged

Fix for SVC fit_proba not using class weights #5912

merged 7 commits into from
Jun 15, 2024

Conversation

pablotanner
Copy link
Contributor

Fixed by passing on sample_weight to the .fit() method in fit_proba() method of SVC.

@pablotanner pablotanner requested a review from a team as a code owner June 1, 2024 14:23
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 1, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jun 1, 2024
@pablotanner pablotanner mentioned this pull request Jun 1, 2024
Closed
dantegd
dantegd approved these changes Jun 3, 2024
View reviewed changes
Copy link
Member

@dantegd dantegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change lgtm

@dantegd dantegd added bug Something isn't working non-breaking Non-breaking change labels Jun 3, 2024
@dantegd
Copy link
Member

dantegd commented Jun 3, 2024

/ok to test

@dantegd
Copy link
Member

dantegd commented Jun 3, 2024

@pablotanner the only issue surfaced in CI was the copyright header year:

--- a/python/cuml/svm/svc.pyx
+++ b/python/cuml/svm/svc.pyx
@@ -1,4 +1,4 @@
-# Copyright (c) 2019-2023, NVIDIA CORPORATION.
+# Copyright (c) 2019-2024, NVIDIA CORPORATION.

Any chance you could update it?

@pablotanner
Copy link
Contributor Author

@dantegd Sure, the year is updated now

@dantegd
Copy link
Member

dantegd commented Jun 4, 2024

/ok to test

dantegd
dantegd requested changes Jun 5, 2024
View reviewed changes
python/cuml/svm/svc.pyx Outdated Show resolved Hide resolved
@pablotanner
Fix issue where sample_weight is None
584be02 
Also added a ValueError, if the SVC has probability=True, class_weights and is being trained with less than 3 classes, because this caused an ambiguous error (unrelated to changes of this PR)
@dantegd
Copy link
Member

dantegd commented Jun 6, 2024

/ok to test

@dantegd
Copy link
Member

dantegd commented Jun 10, 2024

/ok to test

@dantegd
Copy link
Member

dantegd commented Jun 15, 2024

/merge

@rapids-bot rapids-bot bot merged commit 07a3fb9 into rapidsai:branch-24.08 Jun 15, 2024
60 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantegd dantegd dantegd approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Cython / Python Cython or Python issue non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablotanner @dantegd