Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOTFIX] Add compatibility of imports with multiple Scikit-learn versions #5922

Merged
merged 9 commits into from
Jun 12, 2024

Conversation

dantegd
Copy link
Member

@dantegd dantegd commented Jun 6, 2024

closes #5920

PR adds the capability to import cuML with a broader ranged of Scikit-learn versions (tested with 1.2) as opposed to only with the currently tested/supported version (1.5)

@dantegd dantegd requested a review from a team as a code owner June 6, 2024 18:01
@github-actions github-actions bot added the Cython / Python Cython or Python issue label Jun 6, 2024
@dantegd dantegd added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 6, 2024
Copy link
Contributor

@wphicks wphicks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really like the new warnings. Good clarity in terms of what might and what will not be impacted.

@raydouglass raydouglass merged commit 45d963a into rapidsai:branch-24.06 Jun 12, 2024
60 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cython / Python Cython or Python issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants