Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libcuproj doc example and make tests consistent. #1503

Open
wants to merge 2 commits into
base: branch-25.02
Choose a base branch
from

Conversation

harrism
Copy link
Member

@harrism harrism commented Dec 17, 2024

Description

This fixes libcuproj documentation example inconsistencies raised in #1500.

It removes the (outdated) example from the doxygen main_page and replaces it with a link to the readme.

It also makes the type definitions simpler in the README example and makes the Test code match the example.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@harrism harrism requested a review from a team as a code owner December 17, 2024 00:30
@harrism harrism requested review from trxcllnt and isVoid December 17, 2024 00:30
@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Dec 17, 2024
@harrism harrism added doc Documentation non-breaking Non-breaking change and removed libcuspatial Relates to the cuSpatial C++ library labels Dec 17, 2024
@isVoid
Copy link
Contributor

isVoid commented Dec 20, 2024

@harrism I think you just need to merge the changes from #1505 to get the CI passing.

@github-actions github-actions bot added the libcuspatial Relates to the cuSpatial C++ library label Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Documentation libcuspatial Relates to the cuSpatial C++ library non-breaking Non-breaking change
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants