Migrate BFKNN from raft #118
Conversation
benfred
added
improvement
| * the dataset. If the dataset is in host memory, it will be copied to the device and the | ||
| * index will own the device memory. | ||
| */ | ||
| template <typename data_accessor> |
There was a problem hiding this comment.
We need to make sure we are instantiating these for the relevant supported types so they are only being compiled once.
There was a problem hiding this comment.
I've removed this data_accessor template - and changed to having seperate constructors for host/device datasets , with the implementation in the /src/ directory - since I think its a bit cleaner like this
| @@ -18,8 +18,11 @@ | |||
|
|
|||
| #include "ann_types.hpp" | |||
| #include <cuvs/neighbors/ann_types.hpp> | |||
| #include <raft/core/copy.hpp> | |||
There was a problem hiding this comment.
Unfortunately I believe copy brings in device code, I think. Either way, we should break these index files apart into strict interface and compile a source file for the implementation. Then we don't have to worry about exposing anything.
There was a problem hiding this comment.
good callout - I've moved the implementations for the update_dataset code and the constructors to the src/ directory in the last two commits.
I've left the implementations for the getters in the header file since they are trivial, and can be inlined by the compiler then - but can move to src if you think thats better
|
/merge |
Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#118
No description provided.