Add refine to the Python and C api's #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfred
added
improvement
lowener
reviewed
Jun 5, 2024
| dataset : array interface compliant matrix, shape (n_samples, dim) | ||
| Supported dtype [float, int8, uint8] | ||
| queries : array interface compliant matrix, shape (n_queries, dim) | ||
| Supported dtype [float, int8, uint8] |
There was a problem hiding this comment.
Float16 is also supported? Or not in python?
There was a problem hiding this comment.
Thats a good callout! float16 wasn't supported in the python api (and wasn't in the raft python refine api either) - but was supported in the c++ api.
I added support for float16 in the python refine api in the last commit.
cjnolet
approved these changes
Jun 7, 2024
|
/merge |
difyrrwrzd
added a commit
to difyrrwrzd/cuvs
that referenced
this pull request
Aug 10, 2024
Authors: - Ben Frederickson (https://github.com/benfred) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai/cuvs#175
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.