Add cuvs_bench python folder, config files and constraints #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantegd
added
feature request
cjnolet
approved these changes
Jul 25, 2024
| base_file: nytimes-256-inner/base.fbin | ||
| query_file: nytimes-256-inner/query.fbin | ||
| groundtruth_neighbors_file: nytimes-256-inner/groundtruth.neighbors.ibin | ||
| distance: euclidean |
There was a problem hiding this comment.
Probably my fault, but there's several places in the file that say Euclidean when they should say inner.
| file: index/deep-image-96-inner/raft_ivf_pq/dimpq64-cluster1024-float-half | ||
| name: raft_ivf_pq.dimpq64-cluster1024-float-half | ||
| search_params: | ||
| - internalDistanceDtype: float |
There was a problem hiding this comment.
Does this work like? Is the intention here to group these 3 args together?
| @@ -0,0 +1,26 @@ | |||
| dataset: | |||
There was a problem hiding this comment.
I don't think we want to couple the param sweeps dirdftly to the datasets. The whole reason for separating them is that the sweeps should generalize across all datasets (and because it's more manageable to specify the sweeps once, instead of per dataset)
cjnolet
approved these changes
Jul 30, 2024
cjnolet
approved these changes
Jul 30, 2024
|
/merge |
divyegala
pushed a commit
to divyegala/cuvs
that referenced
this pull request
Jul 31, 2024
) Authors: - Dante Gama Dessavre (https://github.com/dantegd) - Corey J. Nolet (https://github.com/cjnolet) Approvers: - Corey J. Nolet (https://github.com/cjnolet) URL: rapidsai#244
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.