Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataset dimension in IVF-PQ C wrappers #292

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Fix dataset dimension in IVF-PQ C wrappers #292

merged 2 commits into from
Aug 14, 2024

Conversation

tfeher
Copy link
Contributor

@tfeher tfeher commented Aug 14, 2024

fixes #288

@tfeher tfeher requested a review from a team as a code owner August 14, 2024 11:57
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 14, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the cpp label Aug 14, 2024
@tfeher tfeher added bug Something isn't working non-breaking Introduces a non-breaking change and removed cpp labels Aug 14, 2024
@tfeher tfeher self-assigned this Aug 14, 2024
@github-actions github-actions bot added the cpp label Aug 14, 2024
@cjnolet
Copy link
Member

cjnolet commented Aug 14, 2024

/ok to test

@cjnolet
Copy link
Member

cjnolet commented Aug 14, 2024

This needs tests but it's fixing a pretty gnarley bug so I'm merging now. I'll create an issue for beefing up our extended API automated tests.

@cjnolet
Copy link
Member

cjnolet commented Aug 14, 2024

/merge

@rapids-bot rapids-bot bot merged commit 9cf4800 into rapidsai:branch-24.10 Aug 14, 2024
46 checks passed
@cjnolet cjnolet mentioned this pull request Aug 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjnolet cjnolet cjnolet approved these changes

Assignees

@tfeher tfeher

Labels
bug Something isn't working cpp non-breaking Introduces a non-breaking change
Projects
VS/ML/DM Primitives Release Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Large memory usage while building IVF-PQ index
2 participants
@tfeher @cjnolet