Updating example notebooks #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjnolet
added
improvement
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## branch-24.10 #294 +/- ##
=============================================
Coverage 70.37% 70.37%
=============================================
Files 12 12
Lines 54 54
=============================================
Hits 38 38
Misses 16 16 ☔ View full report in Codecov by Sentry. |
divyegala
reviewed
Aug 22, 2024
divyegala
approved these changes
Sep 5, 2024
|
/merge |
benfred
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Changes look good - thanks for fixing!
At some point we should automatically run the notebooks as part of CI to verify that they are still working - we used testbook for this before on the Merlin project and it seemed to work well.
|
hopefully CI failure here will be fixed by #314 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.