Simplify libcuvs conda recipe. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
added
improvement
bdice
commented
Sep 10, 2024
| @@ -129,7 +129,8 @@ outputs: | |||
| - ninja | |||
| - {{ stdlib("c") }} | |||
| host: | |||
| - libraft ={{ minor_version }} | |||
| - librmm ={{ minor_version }} | |||
There was a problem hiding this comment.
We need librmm here because we #include it in libcuvs.
| @@ -54,10 +54,8 @@ requirements: | |||
| - pylibraft {{ minor_version }} | |||
| - libcuvs {{ version }} | |||
| - python x.x | |||
| - rmm ={{ minor_version }} | |||
There was a problem hiding this comment.
rmm (Python) is not used directly in cuvs Python code. It is not needed at build or run time.
| @@ -248,6 +248,9 @@ outputs: | |||
| - {{ compiler('cuda') }} | |||
| - cuda-cudart-dev | |||
| - libcublas-dev | |||
| - libcurand-dev | |||
There was a problem hiding this comment.
These changes align libcuvs-examples with the -tests and other packages above. These are needed to build the examples, now that we're removing libraft. Previously libraft was supplying the CUDA math library dependencies.
msarahan
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
I have no additional concerns beyond @cjnolet comment at https://github.com/rapidsai/cuvs/pull/322/files#r1752508397
bdice
commented
Sep 11, 2024
cjnolet
approved these changes
Sep 11, 2024
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the
libcuvsconda recipe to uselibraft-headers-onlyinstead oflibraft.I removed dependencies on
rmmfrom thecuvsbuild -- it is not imported.I included a couple small fixes in CMake and the
cuvsrecipe.